-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS 29: Fee Middleware #276
Merged
Merged
Changes from 1 commit
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
18feadf
scaffolding for 29-fee (#274)
colin-axner 4b9a832
feat: adding proto files for fee payment middleware (#272)
seantking 158a251
fix: removing unncessary fields MsgEscrow & adding query params (#300)
seantking c63af4a
Merge branch 'main' into ics29-fee-middleware
colin-axner e3704c6
feat: #258 Register Counterparty Address (#376)
seantking 70c58af
fix: remove comments for imports (#385)
seantking dd4f8c7
feat: Add handshake logic to ics29 (#307)
AdityaSripal 67bd594
Fee Middleware: Escrow logic (#465)
seantking 405f193
feat: update protos, grpc queries (#488)
charleenfei 8ebbe18
store refund address in IdentifiedPacketFee (#546)
AdityaSripal d419972
29-Fee: Genesis (#557)
seantking 4dbc83e
feat: adding genesis validation + tests (#561)
seantking c4dff6c
feat: add incentivised ack proto (#564)
charleenfei edd11c6
Fee Closing Handshake (#551)
AdityaSripal 885fb9a
Fee Middleware: Add ICS4 wrapper (#562)
seantking a737132
feat: ics 29 packet callbacks (#357)
charleenfei 53b2f67
Merge branch 'main' of github.com:cosmos/ibc-go into ics29-fee-middle…
colin-axner e0cc81a
update imports to v3
colin-axner 120fd76
regenerate proto files
colin-axner 0fbc6bb
fix build
colin-axner dbda885
update ics29 to tip of main (#716)
colin-axner 9285133
fix: event caching for fee distribution (#661)
charleenfei f3e9f95
ics4 callbacks fee middleware (#580)
seantking 26731ce
chore: making PacketId non nullable (#737)
seantking 764df84
nits: proto spacing + naming (#739)
seantking d761982
sean/fix-proto-identified-fee-not-null (#746)
seantking f552fb2
nits: more ics29 nits (#741)
seantking 16e452b
nit: update err syntax (#747)
seantking b16353e
feat: adding Route, Type, GetSignBytes for all messages (#743)
seantking b618f02
hygiene: add validate fn for Fee (#748)
seantking 13f77de
fix: app.go (#789)
seantking 6cb4a38
refactor: ics29 json encoded version metadata (#883)
damiannolan e0161a7
Merge branch 'main' of github.com:cosmos/ibc-go into ics29-fee-middle…
colin-axner dedbb57
chore: bump ics29 to tip of main (#900)
colin-axner 6f19978
fix: return nil on OnRecvPacket for async pay (#911)
seantking ea2984b
nit: ics29 comments (#910)
seantking 323c574
Merge branch 'main' into ics29-fee-middleware
colin-axner fb243c6
chore: Add transfer test for ics29 (#901)
colin-axner 8d226de
refactor: ics29 OnChanOpenInit callback tests now use mock module (#924)
colin-axner 2c1ff0b
feat: allow multiple addrs to incentivize packets (#915)
damiannolan 39ef8d7
chore: remove spec directory from ics29 (#934)
colin-axner 1fb4b5a
refactor: use mock module for ics29 closing handshakes (#926)
colin-axner 9895948
refactor: use mock module for ics29 grpc_query_test.go (#933)
colin-axner acc699d
refactor: readjust keeper_test.go to use mock module (#930)
colin-axner 9b2d96d
fix: fields for genesis should be non nullable (#938)
seantking 06f2730
refactor: use mock module for ics29 escrow_test.go (#932)
colin-axner ff15335
refactor: use mock module for ics29 genesis_test.go (#931)
colin-axner d8b9821
ics29:feat: emit event escrow (#914)
seantking adc66d2
refactor: OnRecvPacket to use mock module (#927)
colin-axner 4326c14
refactor: ics29 OnChanOpenTry/Ack use mock module for testing instead…
colin-axner ad7827f
refactor: use mock module for OnAcknowledgePacket callback testing (#…
colin-axner 7c6076f
refactor: OnTimeoutPacket to use mock module (#928)
colin-axner 179c4f4
chore: add packet id arg to EscrowPacketFee (#951)
damiannolan c14d2b4
chore: remove legacy testing functions (#954)
colin-axner 99db143
fix:ics29: WriteAck update + adding success bool to IncentivizedAck (…
seantking 74afccd
chore: add cli cmd to incentivize existing packet (async) (#965)
colin-axner 6928af7
ics29:fix: counterparty addr must contain channelID (#937)
seantking 6999e10
chore: fix err msg (#971)
colin-axner 4fb6d18
ics29:fix: store source address for query later on WriteAck (#912)
seantking b02d193
refactor: make fee storage more efficient (#956)
damiannolan 15fa37b
chore: update ics29 genesis state to support multiple packet fees (#957)
damiannolan 9350d53
chore: update MsgPayPacketFeeAsync fields (#979)
damiannolan f1ba06f
chore: add ParseKeyFeesInEscrow helper function (#998)
colin-axner fcea26d
chore: update grpc queries to handle multiple fees (#967)
damiannolan 9c508d2
feat: CLI cmd for MsgRegisterCounterpartyAddress (#987)
seantking 7991f79
fix: ics29: switch source with destintion for chan/port IDs (#961)
seantking 9ece5da
test: cleanup 29-fee/types tests (#1006)
damiannolan f8b4345
feat: grpc query total recv packet fees (#1015)
damiannolan e51e2c9
chore: switch code ordering (#1025)
colin-axner 5f8fc9f
feat: Add ParseKeyFeeEnabled and rename FeeEnabledKey -> KeyFeeEnable…
colin-axner 4623772
feat: ics29 cli for query total recv fees (#1035)
damiannolan 8d380ba
feat: grpc query total ack fees (#1032)
damiannolan 9137084
feat: grpc query total timeout fees (#1033)
damiannolan d788adf
feat: adding clis for total ack and timeout queries (#1043)
damiannolan 478db4f
add ParseKeyForwardRelayerAddress function + test (#1046)
charleenfei 71167c4
chore: remove unused ics29 keeper funcs (#1044)
damiannolan 4bf859a
chore: add gRPC for querying incentivized packets for a specific chan…
colin-axner b33b0a7
add function EscrowAccountHasBalance (#1042)
colin-axner f3ee8de
feat: ParseKeyCounterpartyRelayer function (#1047)
charleenfei db88c84
chore: adding queries to cmd builder (#1057)
damiannolan 637652d
chore: update ics29 protodocs (#1055)
damiannolan 4a0e00c
Merge branch 'main' into ics29-fee-middleware
crodriguezvega ab90f07
add counter party channel ID to argument list of on channel open ack …
crodriguezvega 3ab2251
ADR 004: Fee module locking in the presence of severe bugs (#1060)
colin-axner e1cca36
nit: packetID var name (#1214)
seantking e65e881
Merge branch 'main' into ics29-fee-middleware
crodriguezvega 39d4c56
ics29: update with changes from main (#1221)
seantking File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: switch code ordering (#1025)
- Loading branch information
commit e51e2c9917c5786135414ba9fa32fd47efe61b3c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to just disable the fee for all channels on one chain, without notifying the counterparty chains?
According to the logic of
OnRecvPacket
andOnAcknowledgementPacket
, whether the fee module is enabled or not depends on the local state of the chain. So what would happen if one chain has fee enabled and the other chain has fee disabled, either viaDisableAllChannels
or some other corner cases? Would it cause the rawAcknowledgement
to be serialized and deserialized in different ways, thereby causing the deserialization to fail?