Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perform a no-op on redundant relay messages #268

Merged
merged 9 commits into from
Jul 20, 2021
Merged

perform a no-op on redundant relay messages #268

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ffbcec
create initial changes for delivertx handling
colin-axner Jul 15, 2021
990d6a8
handle closed channel no-ops, fix tests
colin-axner Jul 19, 2021
59ad180
self review nits
colin-axner Jul 19, 2021
f45469f
Merge branch 'main' into colin/245-delivertx-redundant-relay
colin-axner Jul 19, 2021
31a55f4
add changelog
colin-axner Jul 19, 2021
beb3d46
Merge branch 'colin/245-delivertx-redundant-relay' of github.com:cosm…
colin-axner Jul 19, 2021
d7443a5
fix merge conflict
colin-axner Jul 19, 2021
560ad17
add events for no op messages
colin-axner Jul 20, 2021
c23ae39
add back comment
colin-axner Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add back comment
  • Loading branch information
@colin-axner
colin-axner committed Jul 20, 2021
commit c23ae390f3df1f7baf6a311bf3f3642626f69c24
1 change: 0 additions & 1 deletion modules/core/04-channel/keeper/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func EmitRecvPacketEvent(ctx sdk.Context, packet exported.PacketI, channel types
// EmitAcknowledgePacketEvent emits an acknowledge packet event. It will be emitted both the first time
// a packet is acknowledged for a certain sequence and for all duplicate acknowledgements.
func EmitAcknowledgePacketEvent(ctx sdk.Context, packet exported.PacketI, channel types.Channel) {
// emit an event marking that we have processed the acknowledgement
ctx.EventManager().EmitEvents(sdk.Events{
sdk.NewEvent(
types.EventTypeAcknowledgePacket,
Expand Down
1 change: 1 addition & 0 deletions modules/core/04-channel/keeper/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ func (k Keeper) AcknowledgePacket(
// log that a packet has been acknowledged
k.Logger(ctx).Info("packet acknowledged", "packet", fmt.Sprintf("%v", packet))

// emit an event marking that we have processed the acknowledgement
EmitAcknowledgePacketEvent(ctx, packet, channel)

return nil
Expand Down