Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/cosmos/cosmos-sdk from 0.46.2 to 0.46.3 #2565

Closed
wants to merge 8 commits into from
Closed

build(deps): bump github.com/cosmos/cosmos-sdk from 0.46.2 to 0.46.3 #2565

wants to merge 8 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2022 •
edited
Loading

Bumps github.com/cosmos/cosmos-sdk from 0.46.2 to 0.46.3.

Release notes

Sourced from github.com/cosmos/cosmos-sdk's releases.

v0.46.3

Cosmos SDK v0.46.3 Release Notes

This is a security release for the Dragonberry security advisory. Please upgrade ASAP.

Next to this, we have also included a few minor bugfixes.

Chains must add the following to their go.mod for the application:

replace github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0

Bumping the SDK version should be smooth, however, feel free to tag core devs to review your upgrading PR:

Changelog

Sourced from github.com/cosmos/cosmos-sdk's changelog.

v0.46.3 - 2022-10-20

ATTENTION:

This is a security release for the Dragonberry security advisory.

All users should upgrade immediately.

Users must add a replace directive in their go.mod for the new ics23 package in the SDK:

replace github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v8.0.0

Features

  • #13435 Extend error context when a simulation fails.
  • (grpc) #13485 Implement a new gRPC query, /cosmos/base/node/v1beta1/config, which provides operator configuration.
  • (cli) #13147 Add the --append flag to the sign-batch CLI cmd to combine the messages and sign those txs which are created with --generate-only.
  • (cli) #13454 sign-batch CLI can now read multiple transaction files.

Improvements

  • #13586 Bump Tendermint to v0.34.22.
  • (auth) #13460 The q auth address-by-id CLI command has been renamed to q auth address-by-acc-num to be more explicit. However, the old address-by-id version is still kept as an alias, for backwards compatibility.
  • #13433 Remove dead code in cacheMergeIterator Domain().

Bug Fixes

  • Implement dragonberry security patch.
  • (store) #13459 Don't let state listener observe the uncommitted writes.
  • #12548 Prevent signing from wrong key while using multisig.

API Breaking Changes

  • (server) #13485 The Application service now requires the RegisterNodeService method to be implemented.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Issues or PRs to update a dependency label Oct 21, 2022
@dependabot dependabot bot requested a review from fedekunze October 21, 2022 13:12
faddat
faddat reviewed Oct 23, 2022
View reviewed changes
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should close this

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cosmos/cosmos-sdk-0.46.3 branch 2 times, most recently from cd74c11 to 312a703 Compare October 25, 2022 07:20
@dependabot
build(deps): bump github.com/cosmos/cosmos-sdk from 0.46.2 to 0.46.3
90694c9 
Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.46.2 to 0.46.3.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.46.2...v0.46.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cosmos/cosmos-sdk-0.46.3 branch from 312a703 to 90694c9 Compare October 25, 2022 16:44
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

4 similar comments
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 27, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022 •
edited
Loading

Codecov Report

Merging #2565 (d0bd595) into main (5260c77) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
- Coverage   78.76%   78.73%   -0.04%     
==========================================
  Files         178      178              
  Lines       12298    12289       -9     
==========================================
- Hits         9687     9676      -11     
- Misses       2188     2190       +2     
  Partials      423      423
Impacted Files Coverage Δ
...ps/27-interchain-accounts/controller/types/msgs.go 91.11% <ø> (-1.05%) ⬇️
...ps/27-interchain-accounts/host/keeper/handshake.go 89.06% <ø> (-0.49%) ⬇️
modules/core/keeper/grpc_query.go 0.00% <0.00%> (ø)
modules/core/02-client/keeper/grpc_query.go 68.20% <100.00%> (ø)
...les/apps/27-interchain-accounts/host/ibc_module.go 90.00% <0.00%> (-5.00%) ⬇️

@colin-axner
Copy link
Contributor

colin-axner commented Oct 31, 2022 •
edited
Loading

Can you run go mod tidy in e2e? Tests are failing

@crodriguezvega
Merge branch 'dependabot/go_modules/github.com/cosmos/cosmos-sdk-0.46…
d0bd595 
….3' of https://github.com/cosmos/ibc-go into dependabot/go_modules/github.com/cosmos/cosmos-sdk-0.46.3
@crodriguezvega
Copy link
Contributor

Superseded by #2647.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 2, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/cosmos/cosmos-sdk-0.46.3 branch November 2, 2022 09:16
@colin-axner colin-axner mentioned this pull request Nov 2, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat left review comments

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
dependencies Issues or PRs to update a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @colin-axner @crodriguezvega @faddat