Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing SubmitTx gRPC endpoint #2147

Merged
merged 11 commits into from
Sep 1, 2022
Merged

feat: implementing SubmitTx gRPC endpoint #2147

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
09c053a
feat: implementing SubmitTx gRPC endpoint
seantking Aug 30, 2022
0a83377
Merge branch 'main' into sean/issue#2056-implement-rpc-handler-ica
seantking Aug 31, 2022
5168cfd
test: adding failure cases
seantking Aug 31, 2022
c83cb4c
add capability test
seantking Aug 31, 2022
d64f950
chore: comment
seantking Aug 31, 2022
06a5bd6
chore: cleanup
seantking Aug 31, 2022
743001a
chore: changelog
seantking Aug 31, 2022
9bed0f5
import & sequence
seantking Aug 31, 2022
084712a
nits
seantking Sep 1, 2022
74c9fbc
refactor: clean up tests
seantking Sep 1, 2022
00c76d8
Merge branch 'main' into sean/issue#2056-implement-rpc-handler-ica
seantking Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: adding failure cases
  • Loading branch information
@seantking
seantking committed Aug 31, 2022
commit 5168cfd90e7c62dee21a513893c76716afb2cb9e
46 changes: 18 additions & 28 deletions modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,37 +113,27 @@ func (suite *KeeperTestSuite) TestSubmitTx() {
},
true,
},
/*
{
"failure - owner address is empty", func() {
owner = ""
connectionId = path.EndpointA.ConnectionID
},
},
{
"failure - active channel does not exist for connection ID", func() {
owner = TestOwnerAddress
connectionId = "connection-100"
},
{
"failure - owner address is empty", func() {
owner = ""
connectionId = path.EndpointA.ConnectionID
},
{
"failure - active channel does not exist for port ID", func() {
owner = "cosmos153lf4zntqt33a4v0sm5cytrxyqn78q7kz8j8x5"
connectionId = path.EndpointA.ConnectionID
},
false,
},
{
"failure - active channel does not exist for connection ID", func() {
owner = TestOwnerAddress
connectionId = "connection-100"
},
{
"failure - module does not own channel capability", func() {
owner = TestOwnerAddress
connectionId = path.EndpointA.ConnectionID
icaMsg = &banktypes.MsgSend{
FromAddress: "source-address",
ToAddress: "destination-address",
Amount: sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(100))),
}
},
false,
},
{
"failure - active channel does not exist for port ID", func() {
owner = "cosmos153lf4zntqt33a4v0sm5cytrxyqn78q7kz8j8x5"
connectionId = path.EndpointA.ConnectionID
},
*/
false,
},
}

for _, tc := range testCases {
Expand Down