-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gofumpt for v3.1.x #1736
gofumpt for v3.1.x #1736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @faddat!
@@ -339,7 +339,8 @@ func (k Keeper) WriteOpenAckChannel( | |||
} | |||
|
|||
// ChanOpenConfirm is called by the counterparty module to close their end of the | |||
// channel, since the other end has been closed. | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as here.
@@ -45,7 +45,8 @@ func (app *SimApp) ExportAppStateAndValidators( | |||
|
|||
// prepare for fresh start at zero height | |||
// NOTE zero height genesis is a temporary feature which will be deprecated | |||
// in favour of export at a block height | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as here.
@@ -335,10 +335,8 @@ lint-fix: | |||
golangci-lint run --fix --out-format=tab --issues-exit-code=0 | |||
.PHONY: lint lint-fix | |||
|
|||
format: | |||
find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name '*.pb.go' | xargs gofmt -w -s | |||
find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name '*.pb.go' | xargs misspell -w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as here.
Description
Designed to make the backport tooling happier, enhance consistency, and make merges easier.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes