fix connection version check in conn open ack

modules/core/03-connection/keeper/handshake.go

@@ -25,7 +25,7 @@ func (k Keeper) ConnOpenInit(
 ) (string, error) {
 	versions := types.GetCompatibleVersions()
 	if version != nil {
-		if !types.IsSupportedVersion(version) {
+		if !types.IsSupportedVersion(types.GetCompatibleVersions(), version) {
 			return "", sdkerrors.Wrap(types.ErrInvalidVersion, "version is not supported")
 		}
 
@@ -179,19 +179,19 @@ func (k Keeper) ConnOpenAck(
 		return sdkerrors.Wrap(types.ErrConnectionNotFound, connectionID)
 	}
 
-	// Verify the provided version against the previously set connection state
-	// connection on ChainA must be in INIT or TRYOPEN
+	// verify the previously set connection state
 	if connection.State != types.INIT {
 		return sdkerrors.Wrapf(
 			types.ErrInvalidConnectionState,
 			"connection state is not INIT (got %s)", connection.State.String(),
 		)
 	}
 
-	if !types.IsSupportedVersion(version) {
+	// ensure selected version is supported
+	if !types.IsSupportedVersion(types.ProtoVersionsToExported(connection.Versions), version) {
 		return sdkerrors.Wrapf(
 			types.ErrInvalidConnectionState,
-			"the provided version is not supported %s", version,
+			"the selected version is not supported %s", version,
 		)
 	}
 

modules/core/03-connection/types/version.go

@@ -117,8 +117,8 @@ func GetCompatibleVersions() []exported.Version {
 // IsSupportedVersion returns true if the proposed version has a matching version
 // identifier and its entire feature set is supported or the version identifier
 // supports an empty feature set.
-func IsSupportedVersion(proposedVersion *Version) bool {
-	supportedVersion, found := FindSupportedVersion(proposedVersion, GetCompatibleVersions())
+func IsSupportedVersion(supportedVersions []exported.Version, proposedVersion *Version) bool {
+	supportedVersion, found := FindSupportedVersion(proposedVersion, supportedVersions)
 	if !found {
 		return false
 	}

modules/core/03-connection/types/version_test.go

@@ -57,7 +57,7 @@ func TestIsSupportedVersion(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		require.Equal(t, tc.expPass, types.IsSupportedVersion(tc.version))
+		require.Equal(t, tc.expPass, types.IsSupportedVersion(types.GetCompatibleVersions(), tc.version))
 	}
 }