Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : add selected channel version to MsgChanOpenInitResponse and MsgChanOpenTryResponse #1279

Merged
merged 10 commits into from
Apr 21, 2022
Merged

chore : add selected channel version to MsgChanOpenInitResponse and MsgChanOpenTryResponse #1279

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
918cafa
add version field in channel proto && gen proto
vuong177 Apr 21, 2022
ed7a082
add version field in msgserver
vuong177 Apr 21, 2022
6d46432
Emit channel version in OpenInit/OpenTry
vuong177 Apr 21, 2022
e4c2d55
minor fixes
vuong177 Apr 21, 2022
6e1de7e
remove yaml tag && run make proto-all
vuong177 Apr 21, 2022
4415722
add changelog entry
vuong177 Apr 21, 2022
87ff80f
add changelog entry
vuong177 Apr 21, 2022
15e7c0d
Merge branch 'main' into selectedVersion
vuong177 Apr 21, 2022
858461b
Update CHANGELOG.md
vuong177 Apr 21, 2022
b96f43a
Update CHANGELOG.md
vuong177 Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add changelog entry
  • Loading branch information
@vuong177
vuong177 committed Apr 21, 2022
commit 441572217ffa12abbe30c4684274bd8f5fcb3f57
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (middleware) [\#1022](https://github.com/cosmos/ibc-go/pull/1022) Add `GetAppVersion` to the ICS4Wrapper interface. This function should be used by IBC applications to obtain their own version since the version set in the channel structure may be wrapped many times by middleware.
* (modules/core/04-channel) [\#1160](https://github.com/cosmos/ibc-go/pull/1160) Improve `uint64 -> string` performance in `Logger`.
* (modules/core/04-channel) [\#1232](https://github.com/cosmos/ibc-go/pull/1232) Updating params on `NewPacketId` and moving to bottom of file.
* (modules/core/04-channel) [\#1232](https://github.com/cosmos/ibc-go/pull/1232) Updating params on `NewPacketId` and moving to bottom of file.
* (modules/core-channel) [\#1279](https://github.com/cosmos/ibc-go/pull/1279) Add selected channel version to MsgChanOpenInitResponse and MsgChanOpenTryResponse. Emit channel version during OpenInit/OpenTry
vuong177 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner Apr 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (modules/core-channel) [\#1279](https://github.com/cosmos/ibc-go/pull/1279) Add selected channel version to MsgChanOpenInitResponse and MsgChanOpenTryResponse. Emit channel version during OpenInit/OpenTry

duplicate entry


### Features

Expand Down