Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficient Consensus State Iteration #125

Merged
merged 12 commits into from
Apr 23, 2021
Merged

Efficient Consensus State Iteration #125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aca247f
start with efficient consensus state lookup
AdityaSripal Apr 15, 2021
24e870c
writeup pruning logic
AdityaSripal Apr 16, 2021
5600cb1
fix tests
AdityaSripal Apr 21, 2021
3f5fe15
add documentation
AdityaSripal Apr 21, 2021
8b9dff1
Merge branch 'main' into aditya/efficient-consensus
AdityaSripal Apr 21, 2021
b5e29f3
improve byte efficiency
AdityaSripal Apr 22, 2021
97e0b30
Merge branch 'aditya/efficient-consensus' of github.com:cosmos/ibc-go…
AdityaSripal Apr 22, 2021
ce002c4
fix tests
AdityaSripal Apr 23, 2021
317bb64
actually fix tests and bug
AdityaSripal Apr 23, 2021
30758d0
deduplicate
AdityaSripal Apr 23, 2021
c0f9513
fix return
AdityaSripal Apr 23, 2021
fb33637
edit changelog
AdityaSripal Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix return
  • Loading branch information
@AdityaSripal
AdityaSripal committed Apr 23, 2021
commit c0f9513cdf3a908406b990c84ee57404feeb0168
1 change: 1 addition & 0 deletions modules/light-clients/07-tendermint/types/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ func getTmConsensusState(clientStore sdk.KVStore, cdc codec.BinaryMarshaler, key
if !ok {
return nil, false
}
return consensusState, true
}

func bigEndianHeightBytes(height exported.Height) []byte {
Expand Down
8 changes: 4 additions & 4 deletions modules/light-clients/07-tendermint/types/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,14 @@ func (suite *TendermintTestSuite) TestPruneConsensusState() {
// this height will be expired but not pruned
path.EndpointA.UpdateClient()
expiredHeight := path.EndpointA.GetClientState().GetLatestHeight()
// store expected values that must still remain in store after pruning

// expected values that must still remain in store after pruning
expectedConsState, ok := path.EndpointA.Chain.GetConsensusState(path.EndpointA.ClientID, expiredHeight)
suite.Require().True(ok)
ctx := path.EndpointA.Chain.GetContext()
clientStore := path.EndpointA.Chain.App.GetIBCKeeper().ClientKeeper.ClientStore(ctx, path.EndpointA.ClientID)
expectedProcessTime, ok := types.GetProcessedTime(clientStore, expiredHeight)
suite.Require().True(ok)
// check iteration key metadata is pruned
expectedConsKey := types.GetIterationKey(clientStore, expiredHeight)
suite.Require().NotNil(expectedConsKey)

Expand Down Expand Up @@ -340,11 +340,11 @@ func (suite *TendermintTestSuite) TestPruneConsensusState() {
consState, ok = path.EndpointA.Chain.GetConsensusState(path.EndpointA.ClientID, expiredHeight)
suite.Require().Equal(expectedConsState, consState, "consensus state incorrectly pruned")
suite.Require().True(ok)
// check processed time metadata is pruned
// check processed time metadata is not pruned
processTime, ok = types.GetProcessedTime(clientStore, expiredHeight)
suite.Require().Equal(expectedProcessTime, processTime, "processed time metadata incorrectly pruned")
suite.Require().True(ok)
// check iteration key metadata is pruned
// check iteration key metadata is not pruned
consKey = types.GetIterationKey(clientStore, expiredHeight)
suite.Require().Equal(expectedConsKey, consKey, "iteration key incorrectly pruned")
}