Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert application state changes on failed acknowledgements #107

Merged
merged 13 commits into from
Apr 12, 2021
Prev Previous commit
Next Next commit
Update modules/core/04-channel/types/acknowledgement.go
  • Loading branch information
colin-axner authored Apr 7, 2021
commit bbd1e38a0f573ee2c9d796335f33e7251360b3f0
2 changes: 1 addition & 1 deletion modules/core/04-channel/types/acknowledgement.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func (ack Acknowledgement) ValidateBasic() error {

// Success implements the Acknowledgement interface. The acknowledgement is
// considered successful if it is a ResultAcknowledgement. Otherwise it is
// considered a failed acknowledgement if it is an ErrorAcknowledgement.
// considered a failed acknowledgement.
func (ack Acknowledgement) Success() bool {
return reflect.TypeOf(ack.Response) == reflect.TypeOf(((*Acknowledgement_Result)(nil)))
}
Expand Down