Closed
Description
openedon Oct 3, 2023
Summary of Bug
Keeper constructors still take paramtypes.Subspace
as a parameter (e.g. https://github.com/cosmos/ibc-go/blob/59e42c6/modules/core/keeper/keeper.go#L43). This requires users to include x/params
to pass in an initialized Subspace
.
Instead, these constructors should take in an interface like cosmos-sdk
modules do (e.g. https://pkg.go.dev/github.com/cosmos/cosmos-sdk@v0.47.5/x/auth#NewAppModule). This allows users to pass in nil
and not have to include x/param types.
Expected Behaviour
See above.
Version
Steps to Reproduce
N/A
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Type
Projects
Status
Done 🥳