Skip to content

x/params deprecated, but users still need to rely on x/param types #4806

Closed

Description

Summary of Bug

Keeper constructors still take paramtypes.Subspace as a parameter (e.g. https://github.com/cosmos/ibc-go/blob/59e42c6/modules/core/keeper/keeper.go#L43). This requires users to include x/params to pass in an initialized Subspace.

Instead, these constructors should take in an interface like cosmos-sdk modules do (e.g. https://pkg.go.dev/github.com/cosmos/cosmos-sdk@v0.47.5/x/auth#NewAppModule). This allows users to pass in nil and not have to include x/param types.

Expected Behaviour

See above.

Version

59e42c6

Steps to Reproduce

N/A


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

type: code hygieneClean up code but without changing functionality or interfaces

Type

No type

Projects

  • Status

    Done 🥳

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions