Skip to content

Use mock stack in callbacks ibc_middleware_test.go #4328

Open
@colin-axner

Description

Summary

Use the mock stack in callbacks ibc_middleware_test.go instead of the transfer stack. This allows for more predictable maintenance of the unit tests. Currently it isn't possible as the mock would need to define its own packet data type which implements the GetSender function. When that functionality is added, the tests can be rewritten to use the mock stack instead of transfer, thus simplifying logic


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned

Metadata

Assignees

No one assigned

    Labels

    callbacks middlewareIssues for callbacks middlewareiceboxIssues that we will not address for the time beingnice-to-have

    Type

    No type

    Projects

    • Status

      No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions