Skip to content

Make port keeper's IsBound a public function #288

Closed

Description

Summary

Port Keeper has a function isBound which checks if the provided portID is already binded to a module.

Problem Definition

ICA needs to check if a portID is already bound, otherwise the port keeper will panic. I realized the current implementation incorrectly checks if the port is bound and does result in a panic. This only occurs if another module claimed a portID within the namespace ICA is working in

The problem was ICA was checking against its scoped keeper, replicating the code in 05-port. But 05-port checks against the IBC scoped keeper. So any port bound that ICA did not claim would cause a panic.

Proposal

The isBound function should be public OR return errors in 05-port instead of panicking #41

cc @AdityaSripal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions