Closed
Description
Summary
In order for ics20 to add a memo field in a backwards compatible fashion we need to not marshal unpopulated fields (memo) on the sending chain. This was the expected behaviour, but upon further investigation by @damiannolan, we have learned the SDK sets EmitDefaults
and subsequently EmitUnpopulated
to true
We should copy/simplify the ProtoMarshalJSON
function and set EmitDefaults to false. This should only be used by ics20 packet data GetBytes
function
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged/assigned