Skip to content

Modify ics20 proto codec to not emit unpopulated fields #2645

Closed
@colin-axner

Description

@colin-axner

Summary

In order for ics20 to add a memo field in a backwards compatible fashion we need to not marshal unpopulated fields (memo) on the sending chain. This was the expected behaviour, but upon further investigation by @damiannolan, we have learned the SDK sets EmitDefaults and subsequently EmitUnpopulated to true

We should copy/simplify the ProtoMarshalJSON function and set EmitDefaults to false. This should only be used by ics20 packet data GetBytes function


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned

Metadata

Metadata

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions