-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use fast unsafe bytes->string convertion #525
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
922a658
perf: use fast unsafe bytes->string convertion
robert-zaremba e334dd3
code style
robert-zaremba 3a5d7f0
update changelog
robert-zaremba 588fa2f
Merge branch 'master' into robert/string-conv
robert-zaremba b91f8b6
Merge branch 'master' into robert/string-conv
robert-zaremba 5c36703
add fast convertions to cache
robert-zaremba 75e7273
Update CHANGELOG.md
robert-zaremba 3203669
one more tiny value cache
robert-zaremba b519af0
Merge remote-tracking branch 'origin/master' into robert/string-conv
robert-zaremba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add fast convertions to cache
- Loading branch information
commit 5c367030a19c28d916d43dff4b67ae49a9b5b62b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that this is helpful because, from my understanding, copying during
[]byte
tostring
conversion when accessing a map by key should be optimized by the Go compiler.Sources:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if the benchmark would remain the same as it is right now if the
map[string]
changes are revertedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can check, however for consistency I prefer to keep the casting here.