Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaia v7 with pebbledb support #1413

Closed
wants to merge 1 commit into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 15, 2022

This is a draft PR for review, of Gaia with PebbleDB.

I am testing against Gaia, because I am having some issues that I suspect may be caused by fast IAVL, so currently doing the same thing for Gaia, that I am doing for Osmoisis, specifically, attempting a sync from genesis. My early findings with Pebble are that it outperforms rocks, while avoiding the troubles of CGO. Both the valnodes team and the notional team have contributed to the PebbleDB implmeentation, in an attempt to get a more rigorous understanding of database performance in cosmos.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1413 (f2531cd) into main (8938fe4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1413   +/-   ##
=======================================
  Coverage   12.13%   12.13%           
=======================================
  Files           9        9           
  Lines        1327     1327           
=======================================
  Hits          161      161           
  Misses       1160     1160           
  Partials        6        6           

@faddat
Copy link
Contributor Author

faddat commented Apr 15, 2022

@okwme
Copy link
Contributor

okwme commented Apr 19, 2022

thanks @faddat , i think the choice to switch db should be considered at the level of the SDK rather on a per-app basis. What do you think about moving this to https://github.com/cosmos/cosmos-sdk?

@faddat
Copy link
Contributor Author

faddat commented May 26, 2022

Billy, unfortunately, this PR is left over from an effort that has failed.

Thanks for your input but I'll need to close this one. I'll continue to work on pebble as best I can.

@faddat faddat closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants