Skip to content

feat: allow serve json rpc request under grpc only mode #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: allow serve json rpc request under grpc only mode #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

- [\#589](https://github.com/cosmos/evm/pull/589) Remove parallelization blockers via migration from transient to object store, refactoring of gas, indexing, and bloom utilities.
- [\#768](https://github.com/cosmos/evm/pull/768) Added ICS-02 Client Router precompile
- [\#826](https://github.com/cosmos/evm/pull/826) Support JSON-RPC queries in gRPC-only mode by connecting to external CometBFT node.

### BUG FIXES

Expand Down
38 changes: 37 additions & 1 deletion server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
pvm "github.com/cometbft/cometbft/privval"
"github.com/cometbft/cometbft/proxy"
rpcclient "github.com/cometbft/cometbft/rpc/client"
rpchttp "github.com/cometbft/cometbft/rpc/client/http"
"github.com/cometbft/cometbft/rpc/client/local"
cmttypes "github.com/cometbft/cometbft/types"

Expand Down Expand Up @@ -424,7 +425,10 @@ func startInProcess(svrCtx *server.Context, clientCtx client.Context, opts Start
if gRPCOnly {
logger.Info("starting node in query only mode; CometBFT is disabled")
config.GRPC.Enable = true
config.JSONRPC.EnableIndexer = false
if config.JSONRPC.Enable {
config.JSONRPC.EnableIndexer = false
logger.Info("JSON-RPC enabled in query-only mode (indexer disabled)")
}
} else {
logger.Info("starting node with ABCI CometBFT in-process")

Expand Down Expand Up @@ -464,10 +468,42 @@ func startInProcess(svrCtx *server.Context, clientCtx client.Context, opts Start
// case, because it spawns a new local CometBFT RPC client.
if (config.API.Enable || config.GRPC.Enable || config.JSONRPC.Enable || config.JSONRPC.EnableIndexer) && bftNode != nil {
clientCtx = clientCtx.WithClient(local.New(bftNode))
app.RegisterTxService(clientCtx)
app.RegisterTendermintService(clientCtx)
app.RegisterNodeService(clientCtx, config.Config)
} else if gRPCOnly && config.JSONRPC.Enable {
// GRPCOnly mode with JSON-RPC: connect to external CometBFT node via --node flag
nodeAddr := clientCtx.NodeURI
if nodeAddr == "" {
nodeAddr = cfg.RPC.ListenAddress
if nodeAddr == "" {
nodeAddr = "tcp://127.0.0.1:26657"
}
}
logger.Info("gRPCOnly mode: connecting to external CometBFT node for JSON-RPC", "address", nodeAddr)

httpClient, err := rpchttp.New(nodeAddr, "/websocket")
if err != nil {
logger.Error("failed to create CometBFT RPC client for gRPCOnly mode", "error", err.Error())
return fmt.Errorf("failed to connect to CometBFT node at %s: %w", nodeAddr, err)
}

if err := httpClient.Start(); err != nil {
logger.Error("failed to start CometBFT RPC client", "error", err.Error())
return fmt.Errorf("failed to start RPC client: %w", err)
}

clientCtx = clientCtx.WithClient(httpClient)
logger.Info("successfully connected to external CometBFT node for JSON-RPC queries")
app.RegisterTxService(clientCtx)
app.RegisterTendermintService(clientCtx)
app.RegisterNodeService(clientCtx, config.Config)

g.Go(func() error {
<-ctx.Done()
logger.Info("stopping CometBFT RPC client")
return httpClient.Stop()
})
}

metrics, err := startTelemetry(config)
Expand Down
Loading