Skip to content

feat: support build tag with rocksdb #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 16, 2025
Merged

feat: support build tag with rocksdb #200

merged 6 commits into from
Jul 16, 2025

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jun 9, 2025

to avoid undefined: config.OpenDB when build with rocksdb

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

mmsqe and others added 2 commits June 9, 2025 09:35
to avoid undefined: config.OpenDB when build with rocksdb
Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to this file/folder? We had a small refactor:

func openDB(_ types.AppOptions, home string, backendType dbm.BackendType) (dbm.DB, error) {

Copy link
Member

@vladjdk vladjdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@aljo242 aljo242 merged commit 6644e35 into cosmos:main Jul 16, 2025
15 checks passed
@mmsqe mmsqe deleted the rocksdb branch August 1, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants