This repository was archived by the owner on Nov 30, 2021. It is now read-only.
Updating ethereum version from fork #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good timing on the 1.9 release: https://blog.ethereum.org/2019/07/10/geth-v1-9-0/ 🎉 Reverts the reverting functionality from commit ChainSafe@3eae07c in PR 😂 |
ansermino
reviewed
Jul 10, 2019
| // ApplyDAOHardFork modifies the state database according to the DAO hard-fork | ||
| // rules, transferring all balances of a set of DAO accounts to a single refund | ||
| // contract. | ||
| func applyDAOHardFork(statedb *evmtypes.CommitStateDB) { |
There was a problem hiding this comment.
Since this is from the geth codebase lets add a reference. This is a link set to the 1.9 commit so it won't change: https://github.com/ethereum/go-ethereum/blob/52f2461774bcb8cdd310f86b4bc501df5b783852/consensus/misc/dao.go#L74
There was a problem hiding this comment.
Probably also worth mentioning why we had to copy it
| // for the transaction, gas used and an error if the transaction failed, | ||
| // indicating the block was invalid. | ||
| func applyTransaction(config *ethparams.ChainConfig, bc ethcore.ChainContext, author *ethcmn.Address, gp *ethcore.GasPool, statedb *evmtypes.CommitStateDB, header *ethtypes.Header, tx *ethtypes.Transaction, usedGas *uint64, cfg ethvm.Config) (*ethtypes.Receipt, uint64, error) { | ||
| msg, err := tx.AsMessage(ethtypes.MakeSigner(config, header.Number)) |
ansermino
approved these changes
Jul 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used a fork of Ethereum as the version of the evm, and this updates the evm to v1.8.27 and does not require using a fork.
Caveats include using a relative version of cosmos-sdk where I had fixed their replace directive to allow the evm to use
golang.org/x/cryptoinstead of having to replace it in this directory. Also I have more or less duplicated partial logic forapplyDAOHardForkandapplyDAOHardForkas the types that are used in the functions currently were not possible to just use the overridden StateDB interface, but I will look into removing either or both.To note, I had updated the go-ethereum version to the current master branch in commit ChainSafe@ef38c33 which I had to revert back to the release version, but if we want to update to the next release, I can refer to these changes to reapply the updates.
local version of the cosmos sdk is https://github.com/ChainSafe/cosmos-sdk (I just committed to master branch) which has a PR in but am waiting on that PR to pass to replace relative dependency with that update before merging this in, but all tests pass with a local version (ignore CI, I'm not updating to pull the fork to get it to pass temporarily).