Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: sims/test expect set to 0 #9971

Merged
merged 1 commit into from
Aug 19, 2021
Merged

fix!: sims/test expect set to 0 #9971

merged 1 commit into from
Aug 19, 2021

Conversation

tac0turtle
Copy link
Member

Description

expected is meant to be 0 not the failed amount. The order doesnt matter greatly, but for consistency sake.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the title fix!: expect set to 0 fix!: sims/test expect set to 0 Aug 19, 2021
@tac0turtle tac0turtle requested a review from amaury1093 August 19, 2021 10:19
@tac0turtle tac0turtle self-assigned this Aug 19, 2021
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #9971 (0d50d6b) into master (cc1e2dd) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9971   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files         566      566           
  Lines       53362    53362           
=======================================
+ Hits        34046    34047    +1     
+ Misses      17397    17396    -1     
  Partials     1919     1919           
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@tac0turtle tac0turtle merged commit b92308e into master Aug 19, 2021
@tac0turtle tac0turtle deleted the marko/fix_equals branch August 19, 2021 13:52
@orijbot
Copy link

orijbot commented Aug 19, 2021

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants