Skip to content

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 2, 2021

Description

Closes: #9361


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@orijbot
Copy link

orijbot commented Aug 3, 2021

Visit https://dashboard.github.orijtech.com?pr=9832&repo=cosmos%2Fcosmos-sdk to see benchmark details.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #9832 (a477306) into master (bdf5aee) will decrease coverage by 0.02%.
The diff coverage is 56.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9832      +/-   ##
==========================================
- Coverage   63.50%   63.47%   -0.03%     
==========================================
  Files         568      568              
  Lines       53257    53271      +14     
==========================================
- Hits        33819    33815       -4     
- Misses      17521    17532      +11     
- Partials     1917     1924       +7     
Impacted Files Coverage Δ
x/bank/keeper/send.go 82.98% <40.00%> (-2.65%) ⬇️
x/bank/migrations/v044/store.go 68.42% <45.45%> (-9.36%) ⬇️
x/bank/keeper/view.go 83.33% <50.00%> (-5.10%) ⬇️
x/bank/keeper/grpc_query.go 47.88% <80.00%> (-0.37%) ⬇️
x/bank/types/key.go 70.00% <100.00%> (-1.43%) ⬇️

@aleem1314 aleem1314 marked this pull request as ready for review August 4, 2021 06:49
@aleem1314 aleem1314 requested a review from amaury1093 August 4, 2021 06:49
@amaury1093 amaury1093 added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Aug 5, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean PR, thanks @aleem1314!

To fix the rosetta test, you can try to run make rosetta-data

@amaury1093 amaury1093 self-assigned this Aug 5, 2021
@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Aug 5, 2021
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 5, 2021
@mergify mergify bot merged commit eb79dd0 into master Aug 5, 2021
@mergify mergify bot deleted the aleem/9361-coin-storage branch August 5, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Rosetta Issues and PR related to Rosetta C:x/bank T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Coin storage model
5 participants