fix: support output flag on tx commands #9717

gsk967 · 2021-07-18T16:37:14Z

Description

Closes: #9684

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…son-to-tx-commands

codecov · 2021-07-22T18:44:47Z

Codecov Report

Merging #9717 (491b18b) into master (adff7d8) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #9717      +/-   ##
==========================================
- Coverage   63.46%   63.31%   -0.15%     
==========================================
  Files         563      563              
  Lines       37504    52726   +15222     
==========================================
+ Hits        23801    33386    +9585     
- Misses      11839    17434    +5595     
- Partials     1864     1906      +42

Impacted Files	Coverage Δ
client/flags/flags.go	`21.05% <0.00%> (-1.17%)`	⬇️
x/staking/migrations/v040/migrate.go	`50.94% <0.00%> (-10.60%)`	⬇️
x/genutil/genesis.go	`40.00% <0.00%> (-10.00%)`	⬇️
x/evidence/keeper/infraction.go	`78.40% <0.00%> (-9.83%)`	⬇️
client/keys/import.go	`57.14% <0.00%> (-7.57%)`	⬇️
store/cache/cache.go	`79.62% <0.00%> (-7.47%)`	⬇️
x/distribution/keeper/hooks.go	`23.68% <0.00%> (-7.27%)`	⬇️
x/slashing/keeper/unjail.go	`41.17% <0.00%> (-6.83%)`	⬇️
crypto/keyring/output.go	`36.11% <0.00%> (-6.75%)`	⬇️
types/codec.go	`60.00% <0.00%> (-6.67%)`	⬇️
... and 554 more

alexanderbez

Thanks @gsk967. I believe you also need to populate the Output field from the flag in readTxCommandFlags.

gsk967 · 2021-07-24T12:59:10Z

@alexanderbez i think output format flag already reading in ReadPersistentCommandFlags

cosmos-sdk/client/cmd.go

Line 90 in adff7d8

    
           func ReadPersistentCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, error) {

alexanderbez

Perfect!

alexanderbez · 2021-07-26T13:21:16Z

@aaronc @AmauryM should we backport this?

orijbot · 2021-07-26T14:13:51Z

Visit https://dashboard.github.orijtech.com?pr=9717&repo=cosmos%2Fcosmos-sdk to see benchmark details.

## Description Closes: #9684  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 9253503)

## Description Closes: #9684  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 9253503) # Conflicts: # CHANGELOG.md

* fix: support output flag on tx commands (#9717)  ## Description Closes: #9684  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 9253503) # Conflicts: # CHANGELOG.md * Fix changelog Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

* fix: support output flag on tx commands (#9717)  ## Description Closes: #9684  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 9253503) * Fix changelog Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

…s#9771) * fix: support output flag on tx commands (cosmos#9717)  ## Description Closes: cosmos#9684  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 9253503) * Fix changelog Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

@jleni

* docs: add v0.43 release version option (backport cosmos#9506) (cosmos#9677) * docs: add v0.43 version option (cosmos#9506) Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> (cherry picked from commit 325dabd) # Conflicts: # docs/versions * fix conflicts Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * chore: Add missing entry in 0.42.7 Changelog (cosmos#9722) * fix: support output flag on tx commands (backport cosmos#9717) (cosmos#9772) * fix: support output flag on tx commands (cosmos#9717)  ## Description Closes: cosmos#9684  * feat: Query txs by signature and by address+seq (backport cosmos#9750) (cosmos#9783) * feat: Query txs by signature and by address+seq (cosmos#9750)  ## Description Closes: cosmos#9741  * fix: hardcoded ledger algo on `keys add` (backport cosmos#9766) (cosmos#9804) * fix: hardcoded ledger algo on `keys add` (cosmos#9766)  ## Description Closes: cosmos#9734 cc: @jleni  * chore: Add Changelog and Release Notes for v0.42.8 (cosmos#9807) * chore: Add Changelog and Release Notes for v0.42.8 * Change date * feat: Improve withdraw-all-rewards UX (backport cosmos#9781) (cosmos#9825) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). * fix: Capability Issue on Restart, Backport to v0.42 (cosmos#9835) * implement BeginBlock fix * add changelog * fix lint * address reviews * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * address reviews * Apply suggestions from code review Co-authored-by: Robert Zaremba <robert@zaremba.ch> * move store check * add api breaking changelog * fix lint Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Fixed the --recover flag not working properly inside the init command (cosmos#9201) (cosmos#9850) Co-authored-by: Alessio Treglia <alessio@tendermint.com> (cherry picked from commit fdbc32e) Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * chore: prepare 0.42.9 release (cosmos#9852) * prepare 0.42.9 release * add 9201 to changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…s#9771) * fix: support output flag on tx commands (cosmos#9717)  ## Description Closes: cosmos#9684  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 9253503) * Fix changelog Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>

Sai Kumar added 3 commits July 18, 2021 21:20

feat: added --output flag to all tx cli commands

56d46c9

removed PrintOutput func

5150d0d

Merge remote-tracking branch 'upstream/master' into sai/9684-pretty-j…

05a5a42

…son-to-tx-commands

github-actions bot added the C:CLI label Jul 18, 2021

Sai Kumar and others added 2 commits July 22, 2021 18:47

updated changelog

fbb344c

Merge branch 'master' into sai/9684-pretty-json-to-tx-commands

dfb5b50

gsk967 marked this pull request as ready for review July 22, 2021 13:19

gsk967 requested review from aaronc and alexanderbez as code owners July 22, 2021 13:19

Merge branch 'master' into sai/9684-pretty-json-to-tx-commands

8557221

alexanderbez suggested changes Jul 23, 2021

View reviewed changes

alexanderbez changed the title ~~Sai/9684 pretty json to tx commands~~ fix: support output flag on tx commands Jul 26, 2021

alexanderbez approved these changes Jul 26, 2021

View reviewed changes

Merge branch 'master' into sai/9684-pretty-json-to-tx-commands

491b18b

alexanderbez requested a review from amaury1093 July 26, 2021 13:25

amaury1093 added backport/0.42.x (Stargate) labels Jul 26, 2021

amaury1093 approved these changes Jul 26, 2021

View reviewed changes

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 26, 2021

mergify bot merged commit 9253503 into cosmos:master Jul 26, 2021

mergify bot mentioned this pull request Jul 26, 2021

fix: support output flag on tx commands (backport #9717) #9771

Merged

mergify bot mentioned this pull request Jul 26, 2021

fix: support output flag on tx commands (backport #9717) #9772

Merged

fedekunze mentioned this pull request Nov 14, 2021

all: cherry pick olympus mons tharsis/cosmos-sdk#1

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: support output flag on tx commands #9717

fix: support output flag on tx commands #9717

gsk967 commented Jul 18, 2021

codecov bot commented Jul 22, 2021 •

edited

Loading

alexanderbez left a comment

gsk967 commented Jul 24, 2021 •

edited

Loading

alexanderbez left a comment

alexanderbez commented Jul 26, 2021 •

edited

Loading

orijbot commented Jul 26, 2021

fix: support output flag on tx commands #9717

fix: support output flag on tx commands #9717

Conversation

gsk967 commented Jul 18, 2021

Description

Author Checklist

Reviewers Checklist

codecov bot commented Jul 22, 2021 • edited Loading

Codecov Report

alexanderbez left a comment

Choose a reason for hiding this comment

gsk967 commented Jul 24, 2021 • edited Loading

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez commented Jul 26, 2021 • edited Loading

orijbot commented Jul 26, 2021

codecov bot commented Jul 22, 2021 •

edited

Loading

gsk967 commented Jul 24, 2021 •

edited

Loading

alexanderbez commented Jul 26, 2021 •

edited

Loading