-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: key rename cli command #9601
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
238dbe2
added key renaming
technicallyty 46762a6
add cli cmds
technicallyty 950752a
changelog
technicallyty 4368e14
gofmt
technicallyty 8283b67
move changelog
technicallyty 9acfb00
fix root_test
technicallyty 16b6632
Apply suggestions from code review
technicallyty ec01a52
Merge branch 'master' into ty/9407-rename_keys_cli
technicallyty 26ec3a5
add equality function
technicallyty 9a2ba38
Update crypto/keyring/keyring.go
technicallyty 2c7395b
move passphrase to const defs
technicallyty 588c082
refactor test
technicallyty ed51363
allow duplicate keys as long as names are different
technicallyty 8d464aa
Merge branch 'master' into ty/9407-rename_keys_cli
technicallyty fc19867
lint
technicallyty c6aed98
Update CHANGELOG.md
technicallyty 3c1e9b9
Update crypto/keyring/keyring.go
technicallyty 4044320
Merge branch 'master' into ty/9407-rename_keys_cli
technicallyty e4d2a3f
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] 2d563b2
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] 1a9347c
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] 102169b
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] e3cca96
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] 3865a9e
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] aae59f9
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] e6f8508
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] e5e35f6
Merge branch 'master' into ty/9407-rename_keys_cli
mergify[bot] 4edd229
Merge branch 'master' into ty/9407-rename_keys_cli
technicallyty c21bd5f
Merge branch 'master' into ty/9407-rename_keys_cli
amaury1093 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update crypto/keyring/keyring.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
- Loading branch information
commit 9a2ba3836a7798ba05fee866ed6ad48be8c3bd26
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this should be a private const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup that makes much more sense - moved it to the other private const vars