Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmos-reflection: extend to support writing by reflection clients #8965

Merged
merged 42 commits into from
Apr 6, 2021
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
5b00df1
change: extend cosmos reflection
fdymylja Mar 23, 2021
5c4702d
add: reflection service implementation
fdymylja Mar 23, 2021
41b56e7
chore: cleanup naming
fdymylja Mar 24, 2021
300f8d6
change: various cleanups
fdymylja Mar 26, 2021
1df455f
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 26, 2021
66be3af
add: tmp
fdymylja Mar 29, 2021
064ef13
change: finalize implementation
fdymylja Mar 29, 2021
d739bd9
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 29, 2021
dc3f543
revert: Makefile
fdymylja Mar 29, 2021
3085a16
Merge remote-tracking branch 'origin/frojdi/issue-8959-extend-cosmos-…
fdymylja Mar 29, 2021
894af90
chore: extend reflection tests
fdymylja Mar 29, 2021
0e2d6f5
chore: fix rosetta CI in the meantime
fdymylja Mar 29, 2021
56fffb0
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 29, 2021
b39062f
chore: lint
fdymylja Mar 29, 2021
6b9f3d2
Merge remote-tracking branch 'origin/frojdi/issue-8959-extend-cosmos-…
fdymylja Mar 29, 2021
a9b66a9
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 29, 2021
f3bf7b7
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 29, 2021
d97aa9c
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
sahith-narahari Mar 30, 2021
4982499
chore: lint the updates from master
fdymylja Mar 30, 2021
493c58a
chore: update CHANGELOG.md
fdymylja Mar 30, 2021
40efff4
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 30, 2021
647753b
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 31, 2021
a2accf3
chore: clarify tx fullname role
fdymylja Mar 31, 2021
8d3d457
change: remove support for legacy msgs
fdymylja Mar 31, 2021
8658687
change: remove deprecated configuration info
fdymylja Mar 31, 2021
33df176
change: enhance servicemsg descriptor
fdymylja Mar 31, 2021
9023090
chore: include comment on response full name for servicemsg descriptor
fdymylja Mar 31, 2021
858b99c
chore: document the rationale of certain implementations
fdymylja Mar 31, 2021
679b0d4
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Mar 31, 2021
ed60e4b
change: add enum descriptor for sign_mode
fdymylja Mar 31, 2021
ee64b21
fix: commit missing file
fdymylja Mar 31, 2021
b51017d
change: split RPCs
fdymylja Apr 1, 2021
74dc667
change: re-add the old v1beta1 reflection service
fdymylja Apr 2, 2021
c71e186
change: add new reflection as v2
fdymylja Apr 2, 2021
637e4ff
chore: cleanup CHANGELOG.md
fdymylja Apr 2, 2021
29492d0
chore: lint
fdymylja Apr 2, 2021
a65bd65
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Apr 2, 2021
528d0c1
chore: cleanup
fdymylja Apr 3, 2021
b4d21e7
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
Apr 4, 2021
a4ccc67
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
fdymylja Apr 6, 2021
839b5b4
Merge branch 'master' into frojdi/issue-8959-extend-cosmos-reflection
sahith-narahari Apr 6, 2021
437d7c7
Merge branch 'master' of github.com:cosmos/cosmos-sdk into frojdi/iss…
sahith-narahari Apr 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ Ref: https://keepachangelog.com/en/1.0.0/
## [Unreleased]

## Features

* [\#8965](https://github.com/cosmos/cosmos-sdk/pull/8965) cosmos reflection now provides more information on the application such as: deliverable msgs, sdk.Config info etc.
* [\#8559](https://github.com/cosmos/cosmos-sdk/pull/8559) Added Protobuf compatible secp256r1 ECDSA signatures.
* [\#8786](https://github.com/cosmos/cosmos-sdk/pull/8786) Enabled secp256r1 in x/auth.
* (rosetta) [\#8729](https://github.com/cosmos/cosmos-sdk/pull/8729) Data API fully supports balance tracking. Construction API can now construct any message supported by the application.
* [\#8754](https://github.com/cosmos/cosmos-sdk/pull/8875) Added support for reverse iteration to pagination.

### Client Breaking Changes

* [\#8965](https://github.com/cosmos/cosmos-sdk/pull/8965) Cosmos reflection import path has changed from `github.com/cosmos/cosmos-sdk/client/grpc/reflection` to `github.com/cosmos/cosmos-sdk/server/grpc/appreflection`
* [\#8363](https://github.com/cosmos/cosmos-sdk/pull/8363) Addresses no longer have a fixed 20-byte length. From the SDK modules' point of view, any 1-255 bytes-long byte array is a valid address.
* [\#8346](https://github.com/cosmos/cosmos-sdk/pull/8346) All CLI `tx` commands generate ServiceMsgs by default. Graceful Amino support has been added to ServiceMsgs to support signing legacy Msgs.
* (crypto/ed25519) [\#8690] Adopt zip1215 ed2559 verification rules.
Expand Down
8 changes: 0 additions & 8 deletions baseapp/grpcrouter.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"google.golang.org/grpc/encoding"
"google.golang.org/grpc/encoding/proto"

"github.com/cosmos/cosmos-sdk/client/grpc/reflection"
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
Expand Down Expand Up @@ -136,13 +135,6 @@ func (qrt *GRPCQueryRouter) RegisterService(sd *grpc.ServiceDesc, handler interf
// also register the interface reflection gRPC service.
func (qrt *GRPCQueryRouter) SetInterfaceRegistry(interfaceRegistry codectypes.InterfaceRegistry) {
qrt.interfaceRegistry = interfaceRegistry

// Once we have an interface registry, we can register the interface
// registry reflection gRPC service.
reflection.RegisterReflectionServiceServer(
qrt,
reflection.NewReflectionServiceServer(interfaceRegistry),
)
}

// returnTypeOf returns the return type of a gRPC method handler. With the way the
Expand Down
45 changes: 0 additions & 45 deletions client/grpc/reflection/reflection.go

This file was deleted.

Loading