Remove requirement for gentx to be only 1 msg #8954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
aaronc,
alessio and
alexanderbez
as code owners
tac0turtle
approved these changes
Mar 23, 2021
sahith-narahari
suggested changes
Mar 23, 2021
| @@ -134,9 +134,6 @@ func CollectTxs(cdc codec.JSONMarshaler, txJSONDecoder sdk.TxDecoder, moniker, g | |||
|
|
|||
| // genesis transactions must be single-message | |||
| msgs := genTx.GetMsgs() | |||
| if len(msgs) != 1 { | |||
| return appGenTxs, persistentPeers, errors.New("each genesis transaction must provide a single genesis message") | |||
| } | |||
|
|
|||
| // TODO abstract out staking message validation back to staking | |||
| msg := msgs[0].(*stakingtypes.MsgCreateValidator) | |||
There was a problem hiding this comment.
I see we're casting it to CreateValidator, shouldn't we change this if we want to support different messages?
There was a problem hiding this comment.
I think we should at least check the type assertion if it is ok.
There was a problem hiding this comment.
Out of scope of this PR, lets open an issue
sahith-narahari
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.