Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude test from race detection #8949

Merged
merged 1 commit into from
Mar 22, 2021
Merged

exclude test from race detection #8949

merged 1 commit into from
Mar 22, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 22, 2021


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #8949 (bb8809a) into master (5bd93bf) will increase coverage by 0.01%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8949      +/-   ##
==========================================
+ Coverage   59.27%   59.29%   +0.01%     
==========================================
  Files         571      572       +1     
  Lines       31827    31846      +19     
==========================================
+ Hits        18867    18884      +17     
- Misses      10757    10758       +1     
- Partials     2203     2204       +1     
Impacted Files Coverage Δ
x/staking/simulation/operations.go 73.16% <60.00%> (-0.30%) ⬇️
x/genutil/client/cli/migrate.go 68.42% <100.00%> (ø)
x/gov/legacy/v043/json.go 100.00% <100.00%> (ø)
x/gov/legacy/v043/store.go 85.71% <100.00%> (+1.09%) ⬆️
x/staking/types/msg.go 55.55% <100.00%> (+0.62%) ⬆️

@alessio alessio merged commit 3361ea9 into master Mar 22, 2021
@alessio alessio deleted the alessio/solve-data-race branch March 22, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants