Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 041: In-Place Store Migrations #8646

Merged
merged 26 commits into from
Mar 4, 2021
Merged
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a23b5fa
Initial draft
amaury1093 Feb 17, 2021
6f69bc5
Draft
amaury1093 Feb 19, 2021
9f24445
Add x/upgrade stuff
amaury1093 Feb 19, 2021
f153843
Tweaks
amaury1093 Feb 19, 2021
6993093
Merge branch 'master' into am/adr-in-place-migrations
jgimeno Mar 3, 2021
0eea75b
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
151149b
Reviews
amaury1093 Mar 4, 2021
01c3507
Merge branch 'am/adr-in-place-migrations' of ssh://github.com/cosmos/…
amaury1093 Mar 4, 2021
6dc29f9
Use migrator
amaury1093 Mar 4, 2021
94c0475
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
2f7fede
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
8494883
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
aaa991b
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
3579a10
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
865713e
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
cb361b7
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
1f1d4ce
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
cbda00b
Merge branch 'am/adr-in-place-migrations' of ssh://github.com/cosmos/…
amaury1093 Mar 4, 2021
31357e6
More fixes
amaury1093 Mar 4, 2021
0fc97c5
Add grpc, use functions
amaury1093 Mar 4, 2021
53a13ab
Add special case with 0 version
amaury1093 Mar 4, 2021
9e07b4d
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
41386ca
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
606aec1
Update docs/architecture/adr-041-in-place-store-migrations.md
amaury1093 Mar 4, 2021
633d07b
Remove useless err return
amaury1093 Mar 4, 2021
dd2b62c
Merge branch 'master' into am/adr-in-place-migrations
mergify[bot] Mar 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/architecture/adr-041-in-place-store-migrations.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ app.UpgradeKeeper.SetUpgradeHandler("my-plan", func(ctx sdk.Context, plan upgrad
})
```

Assuming a chain upgrades at block `N`, the procedure should run as follows:
Assuming a chain upgrades at block `n`, the procedure should run as follows:

- the old binary will halt in `BeginBlock` at block `N`. In its store, the ConsensusVersions of the old binary's modules are stored.
amaury1093 marked this conversation as resolved.
Show resolved Hide resolved
- the new binary will start at block `N`. The UpgradeHandler is set in the new binary, so will run at `BeginBlock` of the new binary. Inside `x/upgrade`'s `ApplyUpgrade`, the `MigrationMap` will be retrieved from the (old binary's) store, and passed into the `RunMigrations` functon, migrating all module stores in-place before the modules' own `BeginBlock`s.
Expand Down