-
Notifications
You must be signed in to change notification settings - Fork 4.1k
add backport label to prs #8609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.mergify.yml
Outdated
| - name: backport patches to v0.41.x branch | ||
| conditions: | ||
| - base=master | ||
| - label=backport-to-v0.41.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - label=backport-to-v0.41.x | |
| - label=backport/0.41.x (Stargate) |
i guess we could just use the existing one, it's used exactly for this purpose (PRs on master that need to be backported)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we adopt a different terminology, please? I'm proposing to replace backport with cherry-pick. It's technically more correct (and it's mergify's default terminology too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh okay, I see people marking the actual backport PR with that label so didnt think it was for that. Good to know we can use it on the original PR.
Can we adopt a different terminology, please? I'm proposing to replace
backportwithcherry-pick. It's technically more correct (and it's mergify's default terminology too)
The mergify term is backport. (https://mergify.io/features/backports) Dont have a preference. Feel free to push to this pr with what has consensus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meh, ok -.- Let's stick to it
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
|
btw thanks @marbar3778 for having a look at this |
Description
to backport a pr add the label
backport-to-v0.41.xfor every release branch, we will need to replace or add an entry.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes