-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: query all accounts stored via gRPC #8522
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8522 +/- ##
=======================================
Coverage 61.47% 61.47%
=======================================
Files 659 659
Lines 37876 37910 +34
=======================================
+ Hits 23283 23304 +21
- Misses 12159 12166 +7
- Partials 2434 2440 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks. proto-docs.md should also be updated, it should be updated automatically when running make proto-all
I can't run this because I get the following error:
P.S. It looks like I'm not the only one: https://discord.com/channels/669268347736686612/680435043570941973/808093567779602442 |
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Co-authored-by: Amaury <amaury.martiny@protonmail.com>
Could you try deleting your Docker containers and running the command again from a fresh start? |
Ok I just pulled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK minor comment. Don't you need to also add the auth client cmd?
…nts-query � Conflicts: � CHANGELOG.md � docs/core/proto-docs.md
Do you think we should add both CLI and REST client commands, or only the CLI one? Since there's the willing to eventually deprecate the REST APIs, I'd implement only the CLI query. |
Yes, CLI is enough. The non-legacy REST endpoint |
Perfect, should have added it |
…nts-query � Conflicts: � x/auth/types/query.pb.gw.go
* Added the ability to query all accounts stored using gRPC * Added CHANGELOG entry * Fixed linting errors * Update CHANGELOG.md Co-authored-by: Amaury <amaury.martiny@protonmail.com> * Update proto/cosmos/auth/v1beta1/query.proto Co-authored-by: Amaury <amaury.martiny@protonmail.com> * Run make proto-all * Merged origin/master * Applied suggestions * Added CLI command * Updated CHANGELOG * Fixed merge conflicts Co-authored-by: Amaury <amaury.martiny@protonmail.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Description
This PR adds the ability to query all the accounts stored on the chain, which might be particularly useful to third party projects like Juno when parsing the chain data from scratch starting at a given height.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes