-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/authz: Add DelegateAuthorization, UndelegateAuthorization #8472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8472 +/- ##
==========================================
+ Coverage 61.43% 61.47% +0.04%
==========================================
Files 658 659 +1
Lines 37768 37876 +108
==========================================
+ Hits 23201 23283 +82
- Misses 12143 12159 +16
- Partials 2424 2434 +10
|
…eem/8312-authz-authorizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just some nits/refactoring requests.
…cosmos/cosmos-sdk into aleem/8312-authz-authorizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @blushi pointed out these are essentially the same message. So we can just include a base message and two types or something like that. Also I imagine we could cover redelegate similarly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving with a few non-blocking comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good now. Let's clean up the docs a bit
Dismissing as my change requests have been addressed
…cosmos/cosmos-sdk into aleem/8312-authz-authorizations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
ref: #8312
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes