[backport/v0.41.x]: Compatibility with the ARM architecture #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
amaury1093,
fdymylja,
jgimeno,
robert-zaremba and
sahith-narahari
alessio
changed the title
jgimeno
approved these changes
Jan 27, 2021
| @@ -91,7 +91,7 @@ func (s *Store) Get(height uint64, format uint32) (*types.Snapshot, error) { | |||
|
|
|||
| // Get fetches the latest snapshot from the database, if any. | |||
| func (s *Store) GetLatest() (*types.Snapshot, error) { | |||
| iter, err := s.db.ReverseIterator(encodeKey(0, 0), encodeKey(math.MaxUint64, math.MaxUint32)) | |||
| iter, err := s.db.ReverseIterator(encodeKey(0, 0), encodeKey(uint64(math.MaxUint64), math.MaxUint32)) | |||
There was a problem hiding this comment.
Why this is needed? Isn't math.MaxUint64 already uint64?
There was a problem hiding this comment.
All casts are related to this Go specification
There was a problem hiding this comment.
No, it's an untyped constant: https://golang.org/ref/spec#Constants (not a bug, a feature! :))
There was a problem hiding this comment.
Yes, exactly. constants will adapt to the expected types. The encodeKey has following declaration:
func encodeKey(height uint64, format uint32) []byte
so the math.MaxUint64 will automatically become uint64 - seems that this conversion is not needed.
There was a problem hiding this comment.
I was actually re-reviewing this and you're right. In master we should revise the code patch as follows:
- revert it
- build multi-arch
- fix build errors one by one
|
Blocked - until concerns raised in #8396 (comment) are addressed |
alessio
force-pushed
the
alessio/backport-8396
branch
from
6ad11b6 to
c06a691
Compare
alessio
added
backports/0.41.x (Stargate)
and removed
S:blocked
clevinson
changed the title
robert-zaremba
approved these changes
Feb 15, 2021
added 2 commits
February 17, 2021 09:22
store/multistore: revert a height limit increase from #8396 See #8396 (comment)
Codecov Report
@@ Coverage Diff @@
## release/v0.41.x #8450 +/- ##
===================================================
- Coverage 61.93% 61.92% -0.01%
===================================================
Files 611 611
Lines 35250 35241 -9
===================================================
- Hits 21831 21822 -9
Misses 11136 11136
Partials 2283 2283
|
amaury1093
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: #8396
Thanks: @RiccardoM for the original patch.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes