Skip to content

Conversation

SegueII
Copy link
Contributor

@SegueII SegueII commented Jan 26, 2021

/supply/total => /bank/total
/supply/total/denom => /bank/total/denom

@SegueII SegueII changed the title Fix legacy rest api (/supply/total=>/bank/total) Fix legacy rest api Jan 26, 2021
@amaury1093
Copy link
Contributor

Thanks @SegueII, could you fix the conflict?

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Btw, did you make this change manually, or did you run a command?

@SegueII
Copy link
Contributor Author

SegueII commented Jan 29, 2021

I changed it manually, but I did not run make commands to update statik.go and swagger.yaml

@amaury1093 amaury1093 requested a review from anilcse February 4, 2021 10:00
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update swagger docs as well? make proto-swagger-gen

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. REST labels Feb 22, 2021
@amaury1093
Copy link
Contributor

@SegueII Could you fix conflicts?

@tac0turtle
Copy link
Contributor

@SegueII please update your branch with master. That way the bot will be able to merge this

@tac0turtle tac0turtle merged commit 92bc290 into cosmos:master Feb 26, 2021
@SegueII SegueII deleted the swagger-fix branch March 1, 2021 10:05
SegueII added a commit to irisnet/cosmos-sdk that referenced this pull request Mar 2, 2021
SegueII added a commit to irisnet/cosmos-sdk that referenced this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants