Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit context background #8093

Merged
merged 14 commits into from
Feb 3, 2021
Merged

Limit context background #8093

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f1a3587
limit context background
cyberbono3 Dec 5, 2020
4b68904
update
cyberbono3 Dec 8, 2020
a031535
fixed minor issues
cyberbono3 Feb 1, 2021
03c9368
fixed TestStatusCommand
cyberbono3 Feb 1, 2021
f9da95a
Fix keyring import from older versions. (#8436)
jgimeno Feb 2, 2021
15d83f5
Add changelog (#8490)
sahith-narahari Feb 2, 2021
ce161c4
fix: tendermint subcommands should not create missing files (#8481)
michaelfig Feb 2, 2021
d4e1d7b
limit context background
cyberbono3 Dec 5, 2020
8d6bad6
update
cyberbono3 Dec 8, 2020
f3cd95c
fixed minor issues
cyberbono3 Feb 1, 2021
070ee85
fixed TestStatusCommand
cyberbono3 Feb 1, 2021
53aebfd
statik.go
cyberbono3 Feb 2, 2021
7562134
Merge branch 'limit-context' of https://github.com/cyberbono3/cosmos-…
cyberbono3 Feb 2, 2021
2c47549
replaced static.go
cyberbono3 Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: tendermint subcommands should not create missing files (#8481) 
If the user specifies an incorrect `--home`, then the old behaviour
would automatically populate it with fresh values, but we should
fail instead.
  • Loading branch information
@michaelfig
michaelfig authored Feb 2, 2021
commit ce161c4f0c52689f199e3d0376b41f581394861e
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/bank) [\#8417](https://github.com/cosmos/cosmos-sdk/pull/8417) Validate balances and coin denom metadata on genesis
* (server) [\#8399](https://github.com/cosmos/cosmos-sdk/pull/8399) fix gRPC-web flag default value
* (client/keys) [\#8436](https://github.com/cosmos/cosmos-sdk/pull/8436) Fix key migration issue
* (server) [\#8481](https://github.com/cosmos/cosmos-sdk/pull/8481) Don't create
files when running `{appd} tendermint show-*` subcommands

## [v0.40.1](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.40.1) - 2021-01-19

Expand Down
6 changes: 3 additions & 3 deletions server/tm_cmds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func ShowNodeIDCmd() *cobra.Command {
serverCtx := GetServerContextFromCmd(cmd)
cfg := serverCtx.Config

nodeKey, err := p2p.LoadOrGenNodeKey(cfg.NodeKeyFile())
nodeKey, err := p2p.LoadNodeKey(cfg.NodeKeyFile())
if err != nil {
return err
}
Expand All @@ -48,7 +48,7 @@ func ShowValidatorCmd() *cobra.Command {
serverCtx := GetServerContextFromCmd(cmd)
cfg := serverCtx.Config

privValidator := pvm.LoadOrGenFilePV(cfg.PrivValidatorKeyFile(), cfg.PrivValidatorStateFile())
privValidator := pvm.LoadFilePV(cfg.PrivValidatorKeyFile(), cfg.PrivValidatorStateFile())
valPubKey, err := privValidator.GetPubKey()
if err != nil {
return err
Expand Down Expand Up @@ -86,7 +86,7 @@ func ShowAddressCmd() *cobra.Command {
serverCtx := GetServerContextFromCmd(cmd)
cfg := serverCtx.Config

privValidator := pvm.LoadOrGenFilePV(cfg.PrivValidatorKeyFile(), cfg.PrivValidatorStateFile())
privValidator := pvm.LoadFilePV(cfg.PrivValidatorKeyFile(), cfg.PrivValidatorStateFile())
valConsAddr := (sdk.ConsAddress)(privValidator.GetAddress())

output, _ := cmd.Flags().GetString(cli.OutputFlag)
Expand Down