Return an unsigned tx in legacy GET /tx endpoint when signature conversion fails #7649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7649 +/- ##
==========================================
- Coverage 54.14% 54.14% -0.01%
==========================================
Files 611 611
Lines 38556 38559 +3
==========================================
Hits 20877 20877
- Misses 15547 15550 +3
Partials 2132 2132 |
aaronc
requested review from
amaury1093,
anilcse,
blushi,
clevinson,
robert-zaremba,
ethanfrey and
zmanian
| @@ -48,7 +49,11 @@ func CopyTx(tx signing.Tx, builder client.TxBuilder) error { | |||
|
|
|||
| err = builder.SetSignatures(sigs...) | |||
| if err != nil { | |||
| return err | |||
| if ignoreSignatureError { | |||
| _ = builder.SetSignatures() | |||
There was a problem hiding this comment.
Why we are calling this second time?
There was a problem hiding this comment.
In case there is any side effect of the initial SetSignatures. For instance maybe there were 2 signatures and 1 was successful but the other wasn't. This call clears all signatures.
There was a problem hiding this comment.
It's already merged, but I still think we should add a comment.
|
I am trying to figure out what exactly would happen when That would trigger the deprecation error message? how does that bubble up. |
It would trigger an error in marshaling. That needs to be addressed, but IMHO separately (#7639) |
…to aaronc/7639-ignore-sig-error
…rsion fails (#7649) * Return an unsigned tx in legacy GET /tx endpoint when signature conversion fails * Add test * add comment * add comment * add comment
ref #7639
This will cause the legacy REST GET
/txendpoint to return an unsigned transaction when the sign mode cannot be represented in amino JSON so that this endpoint fails more gracefully.It WILL NOT fix all errors with the legacy GET
/txendpoint as some tx's (ex. IBC) CANNOT be represented in amino at all.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes