Add CommunitySpendProposals in migration #7607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7607 +/- ##
==========================================
+ Coverage 54.19% 54.21% +0.02%
==========================================
Files 610 611 +1
Lines 38363 38461 +98
==========================================
+ Hits 20791 20852 +61
- Misses 15465 15500 +35
- Partials 2107 2109 +2 |
robert-zaremba
approved these changes
Oct 20, 2020
| RouterKey = ModuleName | ||
|
|
||
| // ProposalTypeCommunityPoolSpend defines the type for a CommunityPoolSpendProposal | ||
| ProposalTypeCommunityPoolSpend = "CommunityPoolSpend" | ||
| ) |
There was a problem hiding this comment.
why don't we import this from x/distribution/types/keys.go?
There was a problem hiding this comment.
Bez preferred to have migration logic self-contained and not rely on the module itself, ref: #6839 (comment).
Note that we're breaking the above rule for >=0.40, as we're now using proto types from the module for 0.40.
4 tasks
zmanian
approved these changes
Oct 20, 2020
amaury1093
added
the
A:automerge
clevinson
pushed a commit
that referenced
this pull request
Oct 20, 2020
* Add CommunitySpendProposals in migration * Fix lint * Avoid double registration Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
9 tasks
clevinson
added a commit
that referenced
this pull request
Oct 20, 2020
* Add CommunitySpendProposals in migration * Fix lint * Avoid double registration Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7601
Add CommunitySpendProposals in v036 distribution, and add correct migration paths until v040.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes