server: catch and return unhandled errors in interceptConfigs #7587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catches and returns unhandled errors after stat-ing for the configFile, instead of assuming that we'd only encounter a non-existent error. Added a regression test to lock-in checks for unhandled errors like Permission errors, which is representative of all the errors that haven't been accounted for. Fixes #7578
odeke-em
requested review from
aaronc,
alessio and
alexanderbez
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7587 +/- ##
=======================================
Coverage 54.19% 54.19%
=======================================
Files 610 610
Lines 38363 38363
=======================================
Hits 20791 20791
Misses 15465 15465
Partials 2107 2107 |
amaury1093
added
the
A:automerge
mergify
bot
deleted the
correctly-check-permissions-for-server-interceptConfigs
branch
|
Thank you for the reviews and merge @amaurymartiny @alexanderbez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches and returns unhandled errors after stat-ing for the configFile,
instead of assuming that we'd only encounter a non-existent error.
Added a regression test to lock-in checks for unhandled errors like
Permission errors, which is representative of all the errors that
haven't been accounted for.
Fixes #7578
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes