Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: enable badgerdb conditional compilation #7396

Merged
merged 4 commits into from
Sep 25, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 25, 2020


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #7396 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7396   +/-   ##
=======================================
  Coverage   55.35%   55.35%           
=======================================
  Files         587      587           
  Lines       36464    36464           
=======================================
  Hits        20184    20184           
  Misses      14192    14192           
  Partials     2088     2088           

Alessio Treglia and others added 2 commits September 25, 2020 15:58
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to remember to document this.

LGTM

@alessio alessio merged commit 0ddb2bd into master Sep 25, 2020
@alessio alessio deleted the alessio/makefile-enable-badgerdb branch September 25, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants