types: start grouping tests in test suites #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7395 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 587 587
Lines 36469 36469
=======================================
Hits 20189 20189
Misses 14192 14192
Partials 2088 2088 |
| @@ -1,4 +1,4 @@ | |||
| package types | |||
| package types_test | |||
There was a problem hiding this comment.
What is the reason of this change?
There was a problem hiding this comment.
When you use separate test packages you put yourself in the developers' shoes and get (almost) the guarantee that a client using the feature which broke in tests will also break when it's called (long story short: the whole point of using _test packages, which incidentally are very Go-idiomatic).
There was a problem hiding this comment.
I think it's a matter of a taste. With _test you are more focused on integration tests, and do potentially imports which could do cycle dependency. Without _test you can access private functions and unit tests them.
robert-zaremba
approved these changes
Sep 26, 2020
alessio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes