-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 030: Authorization Module #7105
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
18b5c8b
Add ADR 030
aaronc fdeaa27
Cleanup
aaronc 2098c59
Updates
aaronc c7fe2c5
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…
aaronc a8e69fd
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…
aaronc e021c9d
Updates based on ADR 031
aaronc 9f14576
Add abstract and context
aaronc 2a823dd
Updates
aaronc 4e593f3
Update module name as per #7615
aaronc 1051cdb
Updates from reviews
aaronc 68372a1
Merge branch 'master' of github.com:cosmos/cosmos-sdk into aaronc/adr…
aaronc 789f45c
Rename
aaronc 14ca1f2
CLI update
aaronc 8cb3c5d
Merge branch 'master' into aaronc/adr-msg-auth
02580d9
Merge branch 'master' into aaronc/adr-msg-auth
aaronc 9e7123d
Update docs/architecture/adr-030-authz-module.md
aaronc e041142
Update docs/architecture/adr-030-authz-module.md
aaronc 4310eb7
Update docs/architecture/adr-030-authz-module.md
aaronc 8f41109
Update docs/architecture/adr-030-authz-module.md
aaronc 39e38f5
Code review updates
aaronc 2017248
Merge remote-tracking branch 'origin/aaronc/adr-msg-auth' into aaronc…
aaronc cc7997f
Update docs
aaronc c2f078b
Merge branch 'master' into aaronc/adr-msg-auth
aaronc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Code review updates
- Loading branch information
commit 39e38f52c703635fb35c181ad7f0c2cd573b4e6b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you specify how this method will call other services? Let's use the
SendAuthorization
example. Willx/authz
have clients to all other modules? How it will inform other module that a message is authorized?I thought that
DispatchActions
will do that. But it seams that theDispatchActions
is used for other modules to callx/authz
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we addressed this when we chatted right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I can add more details in other PR.