Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 030: Authorization Module #7105

Merged
merged 23 commits into from
Jan 13, 2021
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review updates
  • Loading branch information
aaronc committed Jan 13, 2021
commit 39e38f52c703635fb35c181ad7f0c2cd573b4e6b
6 changes: 4 additions & 2 deletions docs/architecture/adr-030-authz-module.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ on behalf of that account to other accounts.
The concrete use cases which motivated this module include:
- the desire to delegate the ability to vote on proposals to other accounts besides the account which one has
delegated stake
- "sub-keys" functionality which is a term used to describe the functionality provided by this module together with
- "sub-keys" functionality, as originally proposed in [\#4480](https://github.com/cosmos/cosmos-sdk/issues/4480) which
is a term used to describe the functionality provided by this module together with
the `fee_grant` module from [ADR 029](./adr-029-fee-grant-module.md) and the [group module](https://github.com/regen-network/cosmos-modules/tree/master/incubator/group).

The "sub-keys" functionality roughly refers to the ability for one account to grant some subset of its capabilities to
Expand All @@ -28,7 +29,7 @@ an organization could grant the ability to spend small amounts of the organizati
Or an individual (or group) with a multisig wallet could grant the ability to vote on proposals to any one of the member
keys.

The sub-keys functionality was originally proposed in https://github.com/cosmos/cosmos-sdk/issues/4480. The current
The current
implementation is based on work done by the [Gaian's team at Hackatom Berlin 2019](https://github.com/cosmos-gaians/cosmos-sdk/tree/hackatom/x/delegation).

## Decision
Expand Down Expand Up @@ -105,6 +106,7 @@ service Msg {
// ExecAuthorized attempts to execute the provided messages using
// authorizations granted to the grantee. Each message should have only
// one signer corresponding to the granter of the authorization.
// The grantee signing this message must have an authorization from the granter.
rpc ExecAuthorized(MsgExecAuthorized) returns (MsgExecAuthorizedResponse)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify how this method will call other services? Let's use the SendAuthorization example. Will x/authz have clients to all other modules? How it will inform other module that a message is authorized?

I thought that DispatchActions will do that. But it seams that the DispatchActions is used for other modules to call x/authz.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we addressed this when we chatted right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can add more details in other PR.



Expand Down