Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: update coin regex #7027

Merged
merged 19 commits into from
Aug 14, 2020
Merged

types: update coin regex #7027

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fbec784
types: update coin regex
fedekunze Aug 12, 2020
497e011
more tests
fedekunze Aug 12, 2020
2b22419
fix test case
fedekunze Aug 12, 2020
9df2c67
increase coverage
fedekunze Aug 12, 2020
431ede8
changelog
fedekunze Aug 12, 2020
afe2627
fix tests
fedekunze Aug 12, 2020
9d4c70e
support unicode letters and numbers
fedekunze Aug 12, 2020
216ebc8
remove ToUpper
fedekunze Aug 12, 2020
595a9d2
Update types/coin.go
fedekunze Aug 12, 2020
cbb88a0
Validate function
fedekunze Aug 13, 2020
88a6874
fix ICS20 test
fedekunze Aug 13, 2020
0bd648f
Merge branch 'master' of github.com:cosmos/cosmos-sdk into update-coi…
fedekunze Aug 13, 2020
e7c09f7
table tests and revert unicodes
fedekunze Aug 13, 2020
94fb4a9
Merge branch 'master' into update-coin-regex
fedekunze Aug 13, 2020
549e121
add test case
fedekunze Aug 13, 2020
12eece3
Merge branch 'update-coin-regex' of github.com:cosmos/cosmos-sdk into…
fedekunze Aug 13, 2020
9945305
Merge branch 'master' of github.com:cosmos/cosmos-sdk into update-coi…
fedekunze Aug 14, 2020
e12e38d
add test cases and comment
fedekunze Aug 14, 2020
928099c
Merge branch 'master' into update-coin-regex
fedekunze Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@fedekunze
fedekunze committed Aug 12, 2020
commit afe26270d4b94242ad57d0c26a7361249d594170
2 changes: 1 addition & 1 deletion types/coin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ func TestCoins(t *testing.T) {
assert.False(t, badSort1.IsValid(), "Coins are not sorted")
assert.False(t, badSort2.IsValid(), "Coins are not sorted")
assert.False(t, badAmt.IsValid(), "Coins cannot include 0 amounts")
assert.False(t, empty.IsValid(), "Invalid coin")
assert.False(t, invalidDenom.IsValid(), "Invalid coin")
assert.False(t, dup1.IsValid(), "Duplicate coin")
assert.False(t, dup2.IsValid(), "Duplicate coin with uppercase")
assert.False(t, dup3.Sort().IsValid(), "Duplicate coins with uppercase")
Expand Down
4 changes: 2 additions & 2 deletions x/bank/types/params_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ func Test_validateSendEnabledParam(t *testing.T) {
{"valid denom send enabled", args{*NewSendEnabled(sdk.DefaultBondDenom, true)}, false},
{"valid denom send disabled", args{*NewSendEnabled(sdk.DefaultBondDenom, false)}, false},

{"invalid denom send enabled", args{*NewSendEnabled("FOO", true)}, true},
{"invalid denom send disabled", args{*NewSendEnabled("FOO", false)}, true},
{"invalid denom send enabled", args{*NewSendEnabled("0FOO", true)}, true},
{"invalid denom send disabled", args{*NewSendEnabled("0FOO", false)}, true},
}
for _, tt := range tests {
tt := tt
Expand Down