store: add test cases for hashing of empty inputs #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
|
@marbar3778 Can you make sure these tests are preserved and updated in the Tendermint upgrade branch? I noticed that this file has been moved on that branch, so take care when resolving conflicts. |
tac0turtle
approved these changes
Aug 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #7004 +/- ##
==========================================
- Coverage 61.86% 59.09% -2.78%
==========================================
Files 520 363 -157
Lines 32108 21432 -10676
==========================================
- Hits 19865 12666 -7199
+ Misses 10628 7722 -2906
+ Partials 1615 1044 -571 |
erikgrinaker
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test cases for hashing of empty inputs. This behavior will change in a breaking manner when upgrading to Tendermint 0.34, due to tendermint/tendermint#5193 which was just merged to
master. Test cases will need to be updated when that happens. A similar change was made to IAVL in cosmos/iavl#304.