-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return error when the address is an empty string #6907
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6907 +/- ##
==========================================
- Coverage 61.82% 61.78% -0.05%
==========================================
Files 520 520
Lines 32129 32147 +18
==========================================
- Hits 19865 19861 -4
- Misses 10656 10676 +20
- Partials 1608 1610 +2 |
ACK @dauTT, but we're 100% going to have to fix some tests. |
Looks good! As @alexanderbez mentioned some tests fail now, should not be a big issue to solve them. |
In many places we do allow to use
In the end the tests fails because the unmarshalling of empty string address does not work anymore: So it seems, after all, not a bad idea to allow empty string in |
|
… These are adresses which are not initialize (e.g AccAddress{}, nil).
Some tests are failing, but I think they are not related to this PR. |
Description
closes: #6760
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes