Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/auth: Finish CLI Refactor #6765

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 17, 2020

Description

Followup from #6573. There are still commands that use the to-be-removed NewContext.

/cc @jgimeno


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:x/auth A:automerge Automatically merge PR once all prerequisites pass. C:CLI labels Jul 17, 2020
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #6765 into master will decrease coverage by 0.80%.
The diff coverage is 6.06%.

@@            Coverage Diff             @@
##           master    #6765      +/-   ##
==========================================
- Coverage   63.49%   62.68%   -0.81%     
==========================================
  Files         262      386     +124     
  Lines       17668    23910    +6242     
==========================================
+ Hits        11218    14989    +3771     
- Misses       5674     7831    +2157     
- Partials      776     1090     +314     

@alexanderbez alexanderbez marked this pull request as ready for review July 17, 2020 19:27
@aaronc aaronc mentioned this pull request Jul 17, 2020
19 tasks
client/rpc/validators.go Show resolved Hide resolved
x/auth/client/cli/query.go Show resolved Hide resolved
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez alexanderbez merged commit e59781e into master Jul 17, 2020
@alexanderbez alexanderbez deleted the bez/6423-in-process-cli-auth branch July 17, 2020 20:20
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants