-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC interface reflection. #6722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6722 +/- ##
==========================================
- Coverage 54.68% 54.66% -0.02%
==========================================
Files 540 541 +1
Lines 36856 36887 +31
==========================================
+ Hits 20153 20165 +12
- Misses 15060 15077 +17
- Partials 1643 1645 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change @aaronc, just a drive by code review from me.
…nc/5921-proto-reflection
…nc/5921-proto-reflection
…nc/5921-proto-reflection
Can you add a bit more to the PR body @aaronc? Thanks for listing the ref, I just wanna be sure of what this changeset includes and why :) |
@alexanderbez I just updated the PR desc answering the "what" question. Concerning the "why", tbh I'm not 100% sure, I see it as a nice-to-have, same as the gRPC reflection itself. Aaron might have a clearer idea. |
I believe it is going to serve a big role when we have types.Any DB
compression, but also for any service to get a listing of all available
types instead of sweating with manually passing them around and registering
which is quite painful to do currently. With this federated service, one
just connects to a specific address and gets a listing of all types
registered and can do their job trivially.
…On Mon, Aug 17, 2020 at 9:42 AM Amaury Martiny ***@***.***> wrote:
@alexanderbez <https://github.com/alexanderbez> I just updated the PR
desc answering the "what" question.
Concerning the "why", tbh I'm not 100% sure, I see it as a nice-to-have,
same as the gRPC reflection itself. Aaron might have a clearer idea.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6722 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3V5FUBWXJLWKPS7ILF3SBFMXFANCNFSM4OZYUC7A>
.
|
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* WIP on gRPC interface reflection. * Update docs in proto * Add tests * Add test * Add route inside router * Address nits * ListInterfaces -> ListAllInterfaces * Fix proto lint * Remove stray println * Update proto/cosmos/base/reflection/v1beta1/reflection.proto Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Update codec/types/interface_registry.go Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Update codec/types/interface_registry.go Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> * Add godoc Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Description
ref: #5921
This PR adds a new gRPC service to do interface registry reflection. Specifically, it adds 2 RPC endpoints:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes