codec: remove unused, untested and expensive MarshalIndentFromJSON #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed as part of an audit that the implementation was expensive, and I've been informed that this function can be removed anyways as it isn't being visibly used and a Github search doesn't turn up useful results: https://github.com/search?q=MarshalIndentFromJSON&type=Issues Fixes #6666
odeke-em
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6667 +/- ##
=======================================
Coverage 57.53% 57.54%
=======================================
Files 501 501
Lines 30023 30018 -5
=======================================
Hits 17274 17274
+ Misses 11504 11499 -5
Partials 1245 1245 |
alexanderbez
reviewed
Jul 9, 2020
alexanderbez
added
A:automerge
Add Alexander's suggestion to remove entry as it was never released. Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed as part of an audit that the implementation was expensive,
and I've been informed that this function can be removed anyways
as it isn't being visibly used and a Github search doesn't turn up
useful results:
https://github.com/search?q=MarshalIndentFromJSON&type=Issues
Fixes #6666
Description
closes: #6666
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes