Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: Remove Viper #6628

Merged
merged 5 commits into from
Jul 7, 2020
Merged

version: Remove Viper #6628

merged 5 commits into from
Jul 7, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 7, 2020

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jul 7, 2020
@alexanderbez alexanderbez self-assigned this Jul 7, 2020
@alexanderbez alexanderbez mentioned this pull request Jul 7, 2020
27 tasks
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #6628 into master will increase coverage by 0.00%.
The diff coverage is 80.76%.

@@           Coverage Diff           @@
##           master    #6628   +/-   ##
=======================================
  Coverage   57.72%   57.73%           
=======================================
  Files         496      496           
  Lines       29731    29735    +4     
=======================================
+ Hits        17162    17167    +5     
+ Misses      11333    11332    -1     
  Partials     1236     1236           

@mergify mergify bot merged commit bc261d9 into master Jul 7, 2020
@mergify mergify bot deleted the bez/6571-viper-removal-cli-version branch July 7, 2020 17:20
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* version: remove viper

* Remove home flag gets

* fix: tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants