Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethanfrey/complete bank send event master #6558

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

tac0turtle
Copy link
Member

Description

replaces #6553

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle tac0turtle added R4R C:x/bank A:automerge Automatically merge PR once all prerequisites pass. labels Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #6558 into master will increase coverage by 4.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6558      +/-   ##
==========================================
+ Coverage   52.77%   56.81%   +4.04%     
==========================================
  Files         316      481     +165     
  Lines       17805    28936   +11131     
==========================================
+ Hits         9396    16440    +7044     
- Misses       7803    11328    +3525     
- Partials      606     1168     +562     

@tac0turtle tac0turtle merged commit 1b4fc78 into master Jul 1, 2020
@tac0turtle tac0turtle deleted the ethanfrey/complete-bank-send-event-master branch July 1, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants