Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments to why its nolint #6366

Merged
merged 3 commits into from
Jun 8, 2020
Merged

add comments to why its nolint #6366

merged 3 commits into from
Jun 8, 2020

Conversation

tac0turtle
Copy link
Member

Description

add reason why things are nolint

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #6366 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6366   +/-   ##
=======================================
  Coverage   55.83%   55.83%           
=======================================
  Files         451      451           
  Lines       27160    27160           
=======================================
  Hits        15166    15166           
  Misses      10902    10902           
  Partials     1092     1092           

@tac0turtle tac0turtle marked this pull request as ready for review June 8, 2020 13:12
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze added A:automerge Automatically merge PR once all prerequisites pass. R4R labels Jun 8, 2020
@mergify mergify bot merged commit b618e0a into master Jun 8, 2020
@mergify mergify bot deleted the linting_fix branch June 8, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants