client: fix Paginate's arguments validation #6205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been For contributor use:
For admin use:
Thank you for your contribution to the Cosmos-SDK! 🚀 |
alessio
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6205 +/- ##
==========================================
+ Coverage 54.85% 54.86% +0.01%
==========================================
Files 444 444
Lines 26785 26787 +2
==========================================
+ Hits 14693 14697 +4
+ Misses 11049 11048 -1
+ Partials 1043 1042 -1 |
Check both page and defLimit against negative values. Follow up of #6205
alessio
force-pushed
the
alessio/fix-client-paginate
branch
from
438e893
to
9416388
Compare
alessio
requested review from
aaronc,
alexanderbez,
clevinson,
fedekunze,
hschoenburg,
jgimeno and
nylira
as code owners
colin-axner
reviewed
May 12, 2020
|
|
||
| // fallback to default limit if supplied limit is invalid | ||
| if limit <= 0 { | ||
| if defLimit < 0 { |
There was a problem hiding this comment.
hmm shouldn't this be defLimit <= 0?
There was a problem hiding this comment.
We'll, in case defLimit is 0 and applied as the actual limit though I think 0 results would be returned. That should be ok.
jgimeno
approved these changes
May 13, 2020
fedekunze
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check both page and defLimit against negative values.
Follow up of #6163