Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix ICS23-Proofs #6178

Closed
wants to merge 9 commits into from
Closed

WIP: Fix ICS23-Proofs #6178

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
73462b2
integrate @ethanfrey work on confio/ics23 into 23-commitment
AdityaSripal May 8, 2020
59d5fd1
start potential chain-proof implementation
AdityaSripal May 18, 2020
567fc51
Update x/ibc/07-tendermint/types/client_state.go
AdityaSripal May 19, 2020
2da7b0d
Update x/ibc/07-tendermint/types/msgs.go
AdityaSripal May 19, 2020
4c38f3e
add GetProofSpecs method to localhost clientstate
AdityaSripal May 19, 2020
dba44d8
Merge branch 'aditya/ics23-proofs' of github.com:cosmos/cosmos-sdk in…
AdityaSripal May 19, 2020
d26a2d8
move specs out of proofs
AdityaSripal May 20, 2020
f605880
implement batch proofs
AdityaSripal May 20, 2020
6c66834
replace MultiStoreProofOp with SimpleValueOp
AdityaSripal May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update x/ibc/07-tendermint/types/msgs.go 
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
  • Loading branch information
@AdityaSripal @fedekunze
AdityaSripal and fedekunze authored May 19, 2020
commit 2da7b0d1c68edaa8bed212419edeb217a1ebdb79
9 changes: 7 additions & 2 deletions x/ibc/07-tendermint/types/msgs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,13 @@ func (msg MsgCreateClient) ValidateBasic() error {
if err := msg.Header.ValidateBasic(msg.Header.ChainID); err != nil {
return sdkerrors.Wrapf(ErrInvalidHeader, "header failed validatebasic with its own chain-id: %v", err)
}
if msg.ProofSpecs != nil {
return sdkerrors.Wrap(ErrInvalidProofSpecs, "proof specs cannot be nil for tendermint client")
if len(msg.ProofSpecs) == 0 {
return sdkerrors.Wrap(ErrInvalidProofSpecs, "proof specs cannot be empty for tendermint client")
}
for i, ps := range msg.ProofSpecs {
if ps == nil {
return fmt.Errorf("proof spec %d cannot be nil", i)
}
}
return host.DefaultClientIdentifierValidator(msg.ClientID)
}
Expand Down