Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/ibc: register missing msgs to codec #6026

Merged
merged 3 commits into from
Apr 20, 2020
Merged

x/ibc: register missing msgs to codec #6026

merged 3 commits into from
Apr 20, 2020

Conversation

jackzampolin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2020 •
edited
Loading

Codecov Report

Merging #6026 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6026   +/-   ##
=======================================
  Coverage   55.11%   55.12%           
=======================================
  Files         430      430           
  Lines       25655    25657    +2     
=======================================
+ Hits        14141    14143    +2     
  Misses      10538    10538           
  Partials      976      976

@jackzampolin
Copy link
Member Author

LGTM?

@fedekunze fedekunze changed the title Add msg ack and timeout to channel codec x/ibc: register missing msgs to codec Apr 19, 2020
@fedekunze
Copy link
Collaborator

@alessio can you remove GolangCI from the required checks? it doesn't work anymore

cwgoes
cwgoes approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio
Copy link
Contributor

alessio commented Apr 20, 2020

Done @fedekunze, I had disabled it for gaia but not for cosmos-sdk.

test-coverage-upload failed due to some unrelated connectivity issues, I'm now rerunning jobs
As soon as the job passed, I'll merge this. Plus, I've also asked @marbar3778 for help in splitting test-coverage-upload up into two jobs, one for test execution and the other for coverage upload. I'll mark only the former as required, so that if the upload fails we won't be blocked.

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 20, 2020
@mergify mergify bot merged commit 758cdd2 into master Apr 20, 2020
@mergify mergify bot deleted the jack/add-msg-codec branch April 20, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmanian zmanian zmanian approved these changes

@alessio alessio alessio approved these changes

@cwgoes cwgoes cwgoes approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackzampolin @fedekunze @alessio @zmanian @cwgoes